(plugin-server-session): delay initialization until first use#2642
Merged
hamudi-ahmed merged 2 commits intonextfrom Dec 16, 2025
Merged
(plugin-server-session): delay initialization until first use#2642hamudi-ahmed merged 2 commits intonextfrom
hamudi-ahmed merged 2 commits intonextfrom
Conversation
gingerbenw
previously approved these changes
Dec 15, 2025
Contributor
|
changelog! |
0eff8fb to
db486cd
Compare
gingerbenw
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Serverless node plugins such as AWS Lambda (and the incoming Cloudflare Workers plugin) use
plugin-browser-sessionand notplugin-server-session, but becauseplugin-server-sessionis bundled with the node notifier as an internal plugin, it's session tracking is still initialized onstart, before any of the external plugins are loaded.This causes problems in some environments like Cloudflare Workers, and results in unnecessary work and leaked timers, since the session delegate is replaced when those plugins are loaded.
Design
This PR fixes the issue by delaying the session tracker initialization until
startSessionis actually called - this preserves the existing behaviour for 'regular' node environments while allowing the serverless plugins to loadplugin-browser-sessionbefore any initialization happens.Testing
Covered by existing tests