Skip to content

Convert @bugsnag/core/lib/derecursify to TypeScript#2428

Merged
gingerbenw merged 18 commits intointegration/typescriptfrom
PLAT-13699-derecursify
Jul 8, 2025
Merged

Convert @bugsnag/core/lib/derecursify to TypeScript#2428
gingerbenw merged 18 commits intointegration/typescriptfrom
PLAT-13699-derecursify

Conversation

@AnastasiiaSvietlova
Copy link
Copy Markdown
Contributor

@AnastasiiaSvietlova AnastasiiaSvietlova commented Apr 25, 2025

Goal

  • Create standalone @bugsnag/derecursify package (private)
  • Add build step to packages that make use of derecursify

Testing

Covered by existing end to end and unit tests

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 25, 2025

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 79.92 kB 18.10 kB
After 79.92 kB 18.10 kB
± No change No change

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against d2332d6

@AnastasiiaSvietlova AnastasiiaSvietlova marked this pull request as ready for review April 28, 2025 09:18
gingerbenw
gingerbenw previously approved these changes Apr 28, 2025
Copy link
Copy Markdown
Member

@gingerbenw gingerbenw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Comment thread packages/core/src/lib/derecursify.ts Outdated
@gingerbenw gingerbenw force-pushed the PLAT-13699-derecursify branch from d86149f to 26a951d Compare May 12, 2025 20:53
@gingerbenw gingerbenw force-pushed the PLAT-13699-derecursify branch from 26a951d to 7f7f693 Compare June 26, 2025 08:12
@gingerbenw gingerbenw requested a review from hamudi-ahmed July 7, 2025 14:10
Copy link
Copy Markdown
Contributor

@hamudi-ahmed hamudi-ahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gingerbenw gingerbenw merged commit 66a7cbb into integration/typescript Jul 8, 2025
48 checks passed
@gingerbenw gingerbenw deleted the PLAT-13699-derecursify branch July 8, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants