Support React Native 0.79 #2410
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| import Bugsnag | ||
|
Contributor
There was a problem hiding this comment. just to confirm, this is the only change between these versions?
Contributor
Author
There was a problem hiding this comment. There's also the The reason we need new before/after fixture files is because the whole |
||
| import UIKit | ||
| import React | ||
| import React_RCTAppDelegate | ||
| import ReactAppDependencyProvider | ||
|
|
||
| @main | ||
| class AppDelegate: UIResponder, UIApplicationDelegate { | ||
| var window: UIWindow? | ||
|
|
||
| var reactNativeDelegate: ReactNativeDelegate? | ||
| var reactNativeFactory: RCTReactNativeFactory? | ||
|
|
||
| func application( | ||
| _ application: UIApplication, | ||
| didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]? = nil | ||
| ) -> Bool { | ||
| Bugsnag.start() | ||
|
|
||
| let delegate = ReactNativeDelegate() | ||
| let factory = RCTReactNativeFactory(delegate: delegate) | ||
| delegate.dependencyProvider = RCTAppDependencyProvider() | ||
|
|
||
| reactNativeDelegate = delegate | ||
| reactNativeFactory = factory | ||
|
|
||
| window = UIWindow(frame: UIScreen.main.bounds) | ||
|
|
||
| factory.startReactNative( | ||
| withModuleName: "reactnative", | ||
| in: window, | ||
| launchOptions: launchOptions | ||
| ) | ||
|
|
||
| return true | ||
| } | ||
| } | ||
|
|
||
| class ReactNativeDelegate: RCTDefaultReactNativeFactoryDelegate { | ||
| override func sourceURL(for bridge: RCTBridge) -> URL? { | ||
| self.bundleURL() | ||
| } | ||
|
|
||
| override func bundleURL() -> URL? { | ||
| #if DEBUG | ||
| RCTBundleURLProvider.sharedSettings().jsBundleURL(forBundleRoot: "index") | ||
| #else | ||
| Bundle.main.url(forResource: "main", withExtension: "jsbundle") | ||
| #endif | ||
| } | ||
| } | ||
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| import UIKit | ||
| import React | ||
| import React_RCTAppDelegate | ||
| import ReactAppDependencyProvider | ||
|
|
||
| @main | ||
| class AppDelegate: UIResponder, UIApplicationDelegate { | ||
| var window: UIWindow? | ||
|
|
||
| var reactNativeDelegate: ReactNativeDelegate? | ||
| var reactNativeFactory: RCTReactNativeFactory? | ||
|
|
||
| func application( | ||
| _ application: UIApplication, | ||
| didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]? = nil | ||
| ) -> Bool { | ||
| let delegate = ReactNativeDelegate() | ||
| let factory = RCTReactNativeFactory(delegate: delegate) | ||
| delegate.dependencyProvider = RCTAppDependencyProvider() | ||
|
|
||
| reactNativeDelegate = delegate | ||
| reactNativeFactory = factory | ||
|
|
||
| window = UIWindow(frame: UIScreen.main.bounds) | ||
|
|
||
| factory.startReactNative( | ||
| withModuleName: "reactnative", | ||
| in: window, | ||
| launchOptions: launchOptions | ||
| ) | ||
|
|
||
| return true | ||
| } | ||
| } | ||
|
|
||
| class ReactNativeDelegate: RCTDefaultReactNativeFactoryDelegate { | ||
| override func sourceURL(for bridge: RCTBridge) -> URL? { | ||
| self.bundleURL() | ||
| } | ||
|
|
||
| override func bundleURL() -> URL? { | ||
| #if DEBUG | ||
| RCTBundleURLProvider.sharedSettings().jsBundleURL(forBundleRoot: "index") | ||
| #else | ||
| Bundle.main.url(forResource: "main", withExtension: "jsbundle") | ||
| #endif | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we drop 0.72 from the matrix yet? I can't remember what the decision was on the support matrix, but 0.76 is now unsupported by react native.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can drop 0.72 - our test matrix policy is the latest 3 versions, plus even versions back to 0.72