Skip to content

Adding support for Hono JS#2375

Merged
hannah-smartbear merged 34 commits intonextfrom
support-hono
May 28, 2025
Merged

Adding support for Hono JS#2375
hannah-smartbear merged 34 commits intonextfrom
support-hono

Conversation

@hannah-smartbear
Copy link
Copy Markdown
Contributor

@hannah-smartbear hannah-smartbear commented Mar 12, 2025 •
edited
Loading

  • Adding support for Hono JS via "@bugsnag/plugin-hono” package with requestHandler and errorHandler functions. Hono is a framework that works with Node and AWS Lambda (among other platforms, but Node and AWS Lambda being ones we support)
  • Added unit tests for the plugin, and feature tests for Hono for Node and for AWS Lambda
  • Also tested locally

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 12, 2025 •
edited
Loading

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 46.96 kB 14.02 kB
After 46.94 kB 14.04 kB
± -24 bytes ⚠️ +11 bytes

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against 952bf60

@hannah-smartbear hannah-smartbear marked this pull request as ready for review March 13, 2025 11:13
@gingerbenw gingerbenw force-pushed the support-hono branch 2 times, most recently from 9b2a9d1 to 72df172 Compare March 14, 2025 15:36
hannah-smartbear and others added 23 commits May 21, 2025 17:37
@hannah-smartbear @gingerbenw
adding tests for hono
dd775bc
@hannah-smartbear @gingerbenw
updating hono app.js in test fixtures
e6dbe99
@gingerbenw
test: ✅ update hono test fixture
6a00124
@hannah-smartbear @gingerbenw
Adding a Hono plugin
6319064
@gingerbenw
fix imports
e8a269b
@gingerbenw
test: ✅ comment out additional test cases while finalising error hand…
5b805f4 
…ling
@gingerbenw
test: ✅ strip down to single working route handler
01159d2
@hannah-smartbear @gingerbenw
latest changes to request handler and tests
3ad1137
@hannah-smartbear @gingerbenw
adding tests to Hono plugin
311b9ea
@hannah-smartbear @gingerbenw
some minor errorHandler changes
3becd0a
@gingerbenw
refactor: ♻️ get error from context
e0ec5fc
@hannah-smartbear @gingerbenw
Adding AWS lambda tests and tidying other tests for Hono
70fc53d
@hannah-smartbear @gingerbenw
updating app-disabled for Hono and adding package-lock.json
6c90729
@hannah-smartbear @gingerbenw
Fixing failing tests for hono
e654f30
@gingerbenw
test: ♻️ add middleware to handle html error pages
14bf801
@gingerbenw
run npm install
b8c4ded
@gingerbenw
restructure middleware in test fixture
c31a16b
@gingerbenw
test: ✅ don't expect lambda response body in unhandled error tests
f396017
@gingerbenw
refactor: ♻️ make errorHandler async as per documentation
dd071ca
@gingerbenw
refactor: ✅ try awaiting a promise before throwing error, as opposed …
5a3349f 
…to setTimeout
@gingerbenw
revert changing error handler to async
dac4858
@gingerbenw
test: ✅ skip type checking for plugin-hono
8630ec5
@gingerbenw
chore: 🏷️ PLAT-14113 reinstate type check for plugin-hono
b67d9c5
gingerbenw
gingerbenw previously approved these changes May 22, 2025
View reviewed changes
Comment thread packages/plugin-hono/test/hono.test.ts
Comment thread test/aws-lambda/features/fixtures/hono-app/app/package.json
Comment thread test/aws-lambda/features/handled.feature Outdated
@gingerbenw gingerbenw requested a review from hamudi-ahmed May 22, 2025 08:55
@gingerbenw
Copy link
Copy Markdown
Member

gingerbenw commented May 22, 2025

@hannah-smartbear - I've added @yousif-bugsnag as a reviewer as well as I had to rebase the PR

gingerbenw
gingerbenw previously approved these changes May 27, 2025
View reviewed changes
@hannah-smartbear hannah-smartbear merged commit 984e1b5 into next May 28, 2025
21 of 22 checks passed
@hannah-smartbear hannah-smartbear deleted the support-hono branch May 28, 2025 08:41
@gingerbenw gingerbenw mentioned this pull request Jun 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hamudi-ahmed hamudi-ahmed Awaiting requested review from hamudi-ahmed

1 more reviewer

@gingerbenw gingerbenw gingerbenw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hannah-smartbear @gingerbenw