Open
Conversation
JamesLindsay0
force-pushed
the
breadcrumbs
branch
from
c6f1ab3 to
ea66ad1
Compare
JamesLindsay0
force-pushed
the
breadcrumbs
branch
2 times, most recently
from
a1e8e68 to
08936bc
Compare
JamesLindsay0
force-pushed
the
breadcrumbs
branch
from
08936bc to
e80b96a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Closes #191
Design
This is in line with the breadcrumb spec except that there is no
removeOnBreadcrumbfunction. This is because it is impossible to compare the callbacks in go.Automatic breadcrumbs for the bugsnag loading and sending errors have been added. Other automatic breadcrumb types can be added later.
Changeset
New functions for
LeaveBreadcrumbandOnBreadcrumb.Testing
Automated tests were added with the http server and to maze runner. I also did some manual testing.