Skip to content

Created BugsnagMetricKitPlugin#1930

Open
robert-smartbear wants to merge 5 commits intointegration/metric-kitfrom
robert/plat-15865_metricKit_prototype
Open

Created BugsnagMetricKitPlugin#1930
robert-smartbear wants to merge 5 commits intointegration/metric-kitfrom
robert/plat-15865_metricKit_prototype

Conversation

@robert-smartbear
Copy link
Copy Markdown
Contributor

Goal

Implemented initial MetricKit integration

Changeset

  • Created a new BugsnagMetricKitPlugin that handles MetricKit diagnostics
  • Created a new example app for metric-kit integration tests

Testing

Manual testing

@github-actions
Copy link
Copy Markdown

Bugsnag.framework binary size increased by 11,376 bytes from 787,016 to 798,392

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +3.8% +5.43Ki  +3.8% +5.43Ki    String Table
  +3.2% +5.20Ki  +3.2% +5.20Ki    Symbol Table
  +2.2% +5.15Ki  +2.2% +5.15Ki    __TEXT,__text
  +4.1% +2.06Ki  +4.1% +2.06Ki    __DATA,__objc_const
  +3.4% +1.02Ki  +3.4% +1.02Ki    __TEXT,__objc_methname
  +4.6%    +911  +4.6%    +911    __TEXT,__cstring
  +2.0%    +576  +2.0%    +576    __TEXT,__objc_stubs
  +3.1%    +438  +1.9%    +454    [12 Others]
  +2.1%    +448  +2.1%    +448    __DATA,__cfstring
   +14%    +360   +14%    +360    __TEXT,__gcc_except_tab
  +7.4%    +320  +7.4%    +320    __DATA,__objc_data
  +2.2%    +168  +2.2%    +168    __DATA,__objc_selrefs
  +3.1%    +136  +3.1%    +136    Lazy Binding Info
  +4.3%    +128  +4.3%    +128    Binding Info
  +3.5%    +128  +3.5%    +128    __TEXT,__unwind_info
  +6.7%     +90  +6.7%     +90    __TEXT,__objc_classname
  +4.2%     +80  +4.2%     +80    Rebase Info
  +2.8%     +60  +2.8%     +60    __TEXT,__stub_helper
 -74.5% -3.14Ki -30.2% -3.16Ki    [__DATA]
 -31.2% -8.36Ki -31.1% -8.36Ki    [__TEXT]
  [DEL]      -4 -72.0% -11.1Ki    [__LINKEDIT]
  +1.4% +11.1Ki  [ = ]       0    TOTAL

Generated by 🚫 Danger

Copy link
Copy Markdown
Contributor

@DariaKunoichi DariaKunoichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants