Conversation
Collaborator
Android notifier sizes
Generated by 🚫 Danger |
Contributor
tomlongridge
left a comment
tomlongridge
left a comment
There was a problem hiding this comment.
Functionally this looks good to me and I'm happy with the version bump levels. My only request is to explain the impact to users in a changelog entry.
lemnik
force-pushed
the
PLAT-14481/version-catalog
branch
from
41978b7 to
7d3a3dc
Compare
tomlongridge
approved these changes
Jul 22, 2025
This was referenced Jul 31, 2025
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Introduce a Gradle Version Catalog instead of our custom
Versionsobject.Changeset
libs.versions.tomlversion catalogminSdkto16(was14)Testing
Relied on existing tests