Skip to content

Offer a delegate EventListener in the okhttp plugin#2206

Merged
YYChen01988 merged 1 commit intonextfrom
PLAT-14334/okHttp-plugin-improvement
Jul 3, 2025
Merged

Offer a delegate EventListener in the okhttp plugin#2206
YYChen01988 merged 1 commit intonextfrom
PLAT-14334/okHttp-plugin-improvement

Conversation

@YYChen01988
Copy link
Copy Markdown
Contributor

@YYChen01988 YYChen01988 commented Jun 30, 2025

Goal

Make it easy for more than a single okhttp EventListener to be used with bugsnag-plugin-android-okhttp

Changeset

Added an optional delegate EventListener to the BugsnagOkHttpPlugin so that more than a single EventListener can be registered.

Testing

Introduced new unit test

@YYChen01988 YYChen01988 requested a review from lemnik as a code owner June 30, 2025 15:56
@YYChen01988 YYChen01988 force-pushed the PLAT-14334/okHttp-plugin-improvement branch from 13295b4 to 9c083fd Compare June 30, 2025 15:58
@bugsnagbot
Copy link
Copy Markdown
Collaborator

bugsnagbot commented Jun 30, 2025

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1828.08 1630.0
arm64_v8a 639.23 438.53
armeabi_v7a 581.9 381.19
x86 708.85 512.24
x86_64 684.28 483.58

Generated by 🚫 Danger

@YYChen01988 YYChen01988 force-pushed the PLAT-14334/okHttp-plugin-improvement branch 4 times, most recently from e63e2ba to f8271d7 Compare July 1, 2025 08:33
@YYChen01988 YYChen01988 requested a review from lemnik July 1, 2025 08:34
@YYChen01988 YYChen01988 force-pushed the PLAT-14334/okHttp-plugin-improvement branch from f8271d7 to 8a366ed Compare July 1, 2025 08:46
@lemnik lemnik changed the title Enhance okhttp plugin support Offer a delegate EventListener in the okhttp plugin Jul 3, 2025
@YYChen01988 YYChen01988 force-pushed the PLAT-14334/okHttp-plugin-improvement branch from 8a366ed to 11183b1 Compare July 3, 2025 07:57
@YYChen01988 YYChen01988 requested a review from lemnik July 3, 2025 07:58
@YYChen01988 YYChen01988 force-pushed the PLAT-14334/okHttp-plugin-improvement branch from 11183b1 to 2ae97e8 Compare July 3, 2025 09:50
@YYChen01988 YYChen01988 requested a review from lemnik July 3, 2025 09:57
Copy link
Copy Markdown
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YYChen01988 YYChen01988 merged commit 143824f into next Jul 3, 2025
35 checks passed
@YYChen01988 YYChen01988 deleted the PLAT-14334/okHttp-plugin-improvement branch July 3, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants