Skip to content

Set default endpoints based on API key#2190

Merged
richardelms merged 8 commits intonextfrom
plat-14263
May 30, 2025
Merged

Set default endpoints based on API key#2190
richardelms merged 8 commits intonextfrom
plat-14263

Conversation

@richardelms
Copy link
Copy Markdown
Contributor

@richardelms richardelms commented May 26, 2025

Goal

Set default endpoints based on API key. If no endpoint is configured, payloads should be sent to *.insighthub.smartbear.com if the API key starts with 00000.

Changeset

  • changed ConfigInternal.kt to return the correct defaults based on api key if no custom endpoints have been configured.
  • added comparison methods to EndpointConfiguration class to ensure unit tests compare the values of the endpoints inside rather than the objects.

Testing

Added unit tests

@bugsnagbot
Copy link
Copy Markdown
Collaborator

bugsnagbot commented May 26, 2025

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1831.74 1634.54
arm64_v8a 639.23 442.63
armeabi_v7a 577.8 377.1
x86 717.04 516.34
x86_64 684.28 483.58

Generated by 🚫 Danger

@richardelms richardelms marked this pull request as ready for review May 30, 2025 10:57
Copy link
Copy Markdown
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardelms richardelms merged commit 035d9d3 into next May 30, 2025
35 checks passed
@richardelms richardelms deleted the plat-14263 branch May 30, 2025 14:13
@lemnik lemnik mentioned this pull request Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants