Change to discardOldestFileIfNeeded sorting#2189
Merged
Conversation
Collaborator
Android notifier sizes
Generated by 🚫 Danger |
lemnik
reviewed
Jun 3, 2025
lemnik
reviewed
Jun 9, 2025
Contributor
Author
|
Hey @lemnik |
lemnik
force-pushed
the
Crash-in-discardOldestFileIfNeeded
branch
2 times, most recently
from
516eaa6 to
4d22cc9
Compare
…re.kt Co-authored-by: Jason <lemnik@users.noreply.github.com>
…re.kt Co-authored-by: Jason <lemnik@users.noreply.github.com>
…re.kt Co-authored-by: Jason <lemnik@users.noreply.github.com>
…verted the `isStorageDirValid` of `discardOldestFileIfNeeded`
lemnik
force-pushed
the
Crash-in-discardOldestFileIfNeeded
branch
from
4d22cc9 to
d57176c
Compare
lemnik
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Fix rare
"Comparison method violates its general contract!"crashes indiscardOldestFileIfNeededwhen the file timestamps change during thesort().Design
Capture all of the
lastModified()timestamps into a stable list before sorting.Testing
Relied on existing tests