Add CUDA bundle adjustment support - #1137
Open
Kusum-mrv20 wants to merge 6 commits into
Open
Conversation
Author
|
@kathirgounder can you please provide some initial reviews on these changes, have done sanity tests on small datasets, but can do further tests after first reviews |
Expose optimizer duration and document ~7.7x Sparse LM speedup on the benchmark scene for review. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
Hi Prof. @dellaert |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
uv run pytest tests/bundle/test_bundle_adjustment.py -q: 15 passeddubrovnik-3-7-pre: error 691.0550 -> 0.3675dubrovnik-3-7-18-pre: error 688.2935 -> 0.0092Gerrard Hall timing (for review)
CPU vs CUDA Sparse LM on the Gerrard Hall COLMAP sparse model (~100 cameras, ~43k tracks), measured with:
bash .github/scripts/download_single_benchmark.sh gerrard-hall-100 wget uv run pytest tests/bundle/test_cuda_ba_timing.py -m "slow and cuda" -s --no-covRepresentative local result on an RTX 3080 (PCG backend, reprojection-only graph,
max_iterations=50):gtsam.LevenbergMarquardtOptimizer_last_optimization_duration_sec