Skip to content

Fix platform label context in rule transitions #3997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tamasvajk wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix platform label context in rule transitions #3997

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16b203a
Fix platform label context in rule transitions
Apr 28, 2026
891ae9f
Fix _resolve_platform to check string prefix, not repo_name
Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions rust/private/rust.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1006,9 +1006,24 @@ rust_library = rule(
"""),
)

def _resolve_platform(settings, attr):
"""Resolve the platform label for a transition, adding @ prefix if needed.

With --noincompatible_unambiguous_label_stringification, str(label) for
main-repo labels omits the leading @, producing "//foo:bar" instead of
"@//foo:bar". The platform setting requires the canonical form with @.
See https://github.com/bazelbuild/bazel/issues/15916.
"""
if not attr.platform:
return settings["//command_line_option:platforms"]
platform = str(attr.platform)
if not platform.startswith("@"):
platform = "@" + platform
return platform

def _rust_static_library_transition_impl(settings, attr):
return {
"//command_line_option:platforms": str(attr.platform) if attr.platform else settings["//command_line_option:platforms"],
"//command_line_option:platforms": _resolve_platform(settings, attr),
}

_rust_static_library_transition = transition(
Expand Down Expand Up @@ -1049,7 +1064,7 @@ rust_static_library = rule(

def _rust_shared_library_transition_impl(settings, attr):
return {
"//command_line_option:platforms": str(attr.platform) if attr.platform else settings["//command_line_option:platforms"],
"//command_line_option:platforms": _resolve_platform(settings, attr),
}

_rust_shared_library_transition = transition(
Expand Down Expand Up @@ -1171,7 +1186,7 @@ _RUST_BINARY_ATTRS = {

def _rust_binary_transition_impl(settings, attr):
return {
"//command_line_option:platforms": str(attr.platform) if attr.platform else settings["//command_line_option:platforms"],
"//command_line_option:platforms": _resolve_platform(settings, attr),
}

_rust_binary_transition = transition(
Expand Down Expand Up @@ -1418,7 +1433,7 @@ rust_test_without_process_wrapper_test = rule(

def _rust_test_transition_impl(settings, attr):
return {
"//command_line_option:platforms": str(attr.platform) if attr.platform else settings["//command_line_option:platforms"],
"//command_line_option:platforms": _resolve_platform(settings, attr),
}

_rust_test_transition = transition(
Expand Down
Loading