Fix rust_bindgen compile flag filtering#3363
Merged
UebelAndre merged 2 commits intobazelbuild:mainfrom Mar 18, 2025
bmclarnon:bindgen
Merged
Fix rust_bindgen compile flag filtering#3363UebelAndre merged 2 commits intobazelbuild:mainfrom bmclarnon:bindgen
UebelAndre merged 2 commits intobazelbuild:mainfrom
bmclarnon:bindgen
Conversation
All flags were treated as accepting a parameter, causing any argument following a parameterless flag (e.g. `-no-standard-includes`) to be passed through. This causes bindgen failures if the next argument isn't supported by clang. `-nostd*` flags has also been expanded using https://clang.llvm.org/docs/ClangCommandLineReference.html to make it clearer that these flags are parameterless. Since these flags resulted in a prefix match, not a full match, they wouldn't set `open_arg = True` and therefore wouldn't cause issues, but this behavior is unnecessarily subtle now that there are two lists. Fixes #3359
Collaborator
|
@bmclarnon looks like buildifier needs to run. |
Contributor
Author
|
@UebelAndre Oops, sorry I missed that! And thanks for the really quick review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All flags were treated as accepting a parameter, causing any argument following a parameterless flag (e.g.
-no-standard-includes) to be passed through. This causes bindgen failures if the next argument isn't supported by clang.-nostd*flags has also been expanded usinghttps://clang.llvm.org/docs/ClangCommandLineReference.html to make it clearer that these flags are parameterless. Since these flags resulted in a prefix match, not a full match, they wouldn't set
open_arg = Trueand therefore wouldn't cause issues, but this behavior is unnecessarily subtle now that there are two lists.Fixes #3359