Conversation
fmeum
changed the title
fmeum
force-pushed
the
rewind-lost-repo-files-1
branch
from
September 13, 2026 17:34
240a05e to
c60a53b
Compare
fmeum
changed the title
fmeum
marked this pull request as ready for review
September 13, 2026 17:35
github-actions
Bot
added
team-ExternalDeps
fmeum
force-pushed
the
rewind-lost-repo-files-1
branch
from
September 13, 2026 21:29
c60a53b to
1b09be7
Compare
fmeum
changed the title
fmeum
force-pushed
the
rewind-lost-repo-files-1
branch
3 times, most recently
from
September 14, 2026 10:39
63fc191 to
a0f019e
Compare
The tests for files that the remote repo contents cache has lost set up a very particular kind of failure and run several builds each, so they get their own target with its own setup instead of growing the general remote repo contents cache suite. The setup shared by both suites moves into a base class, and the repo with a root and a subpackage BUILD file that the existing test builds becomes a helper for the tests that follow.
fmeum
force-pushed
the
rewind-lost-repo-files-1
branch
from
September 14, 2026 11:30
a0f019e to
a6e60a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The tests for files that the remote repo contents cache has lost set up a very particular kind of failure and run several builds each, so they get their own target,
remote_repo_contents_cache_rewinding_test, with its own setup instead of growing the generalremote_repo_contents_cache_testsuite. The setup shared by both suites moves into a base class, and the repo with a root and a subpackage BUILD file that the existing test builds becomes a helper for the tests that follow.Motivation
First step of a stack that recovers repo files lost from the remote repo contents cache by rewinding the repo fetch within the same command (#30218). No behavior change.
Build API Changes
No
Release Notes
RELNOTES: None