Adds gltfpacker target to meshoptimizer 1.2 - #10535

Merged

bazel-io merged 1 commit into

bazelbuild:mainfrom

dgoel:dgoel/gltfpacker

Sep 15, 2026

dgoel commented Sep 13, 2026

Contributor

No description provided.

dgoel commented Sep 13, 2026

Contributor Author

@bazel-io skip_check unstable_url

bazel-io added the skip-url-stability-check label

dgoel marked this pull request as ready for review

September 13, 2026 17:35

bazel-io commented Sep 13, 2026

Member

Hello @Vertexwahn, modules you maintain (meshoptimizer) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

dgoel commented Sep 15, 2026

Contributor Author

@Vertexwahn gentle ping for review! Let me know if you'd be okay if I add myself as another maintainer.

Vertexwahn commented Sep 15, 2026

Contributor

Fell free to add yourself as a maintainer! It's always good to have more than one...

dgoel commented Sep 15, 2026

Contributor Author

Sounds good. I can do that in a follow-up PR. If you can review and approve this one, that'd be great!

Vertexwahn reviewed

View reviewed changes

modules/meshoptimizer/1.2.bcr.0/overlay/test_module/MODULE.bazel Outdated

Vertexwahn reviewed

View reviewed changes

modules/meshoptimizer/1.2.bcr.0/overlay/test_module/MODULE.bazel Outdated

Vertexwahn reviewed

View reviewed changes

modules/meshoptimizer/1.2.bcr.0/overlay/MODULE.bazel Outdated

Vertexwahn reviewed

View reviewed changes

modules/meshoptimizer/1.2.bcr.0/overlay/MODULE.bazel Outdated

Vertexwahn reviewed

View reviewed changes

modules/meshoptimizer/1.2.bcr.0/MODULE.bazel Outdated

Vertexwahn reviewed

View reviewed changes

modules/meshoptimizer/1.2.bcr.0/MODULE.bazel Outdated

Vertexwahn reviewed

View reviewed changes

modules/meshoptimizer/metadata.json Outdated

Vertexwahn suggested changes

View reviewed changes

dgoel force-pushed the dgoel/gltfpacker branch from e31b466 to 4207e43 Compare

September 15, 2026 16:44

dgoel commented Sep 15, 2026

Contributor Author

@Vertexwahn addressed your comments. I rewrote the history as I had to rename the top folder. Using "Generate module diff" from CI pipeline is the easiest option to see the changes wrt v1.2.

dgoel requested a review from Vertexwahn

September 15, 2026 16:48

Vertexwahn previously approved these changes

View reviewed changes

bazel-io previously approved these changes

View reviewed changes

bazel-io left a comment

Member

All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.

bazel-io added the presubmit-auto-run label


          Adds gltfpacker target to meshoptimizer module

f0aeec0

dgoel force-pushed the dgoel/gltfpacker branch from 4207e43 to f0aeec0 Compare

September 15, 2026 19:35

bazel-io dismissed stale reviews from Vertexwahn and themself

September 15, 2026 19:35

Require module maintainers' approval for newly pushed changes.

bazel-io requested a review from Vertexwahn

September 15, 2026 19:35

Vertexwahn approved these changes

View reviewed changes

dgoel requested a review from bazel-io

September 15, 2026 20:58

bazel-io approved these changes

View reviewed changes

bazel-io left a comment

Member

All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.

bazel-io merged commit 3d667d3 into bazelbuild:main

20 checks passed

bazel-io added the auto-merged label

dgoel deleted the dgoel/gltfpacker branch

September 15, 2026 22:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merged presubmit-auto-run skip-url-stability-check