feat: add root namespace to skip forwarding#185
Open
wikando-ck wants to merge 1 commit intobamarni:masterfrom
Open
feat: add root namespace to skip forwarding#185wikando-ck wants to merge 1 commit intobamarni:masterfrom
wikando-ck wants to merge 1 commit intobamarni:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #169
Composer does not allow adding options - it will reject them and fail.
So I had to go with a
rootnamespace and to usecomposer binin the call instead of justcomposer update --no-bin-forward.both will require us to change the commands.
So maybe going with #154 would be even better, as we can use standard commands (which might already exist in makefiles, ci) and just configure the ones we don't want to forward in
composer.json.