fix: Don't rethrow in DisposeComponents directly#1764
Merged
linkdotnet merged 1 commit intomainfrom Oct 7, 2025
Merged
Conversation
1667f7a to
968a4ab
Compare
Member
|
Horray, great catch! |
egil
approved these changes
Oct 7, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a race condition in the DisposeComponents method by removing the immediate exception rethrowing behavior and consolidating exception handling through the Renderer.UnhandledException task. The change addresses flakiness in Test201 by ensuring consistent behavior for both synchronous and asynchronous disposal exceptions.
- Removed immediate
AssertNoUnhandledExceptions()call fromDisposeComponentsmethod - Updated test expectations to check exceptions via
Renderer.UnhandledExceptioninstead of expecting direct throws - Updated documentation to reflect the new consistent exception handling pattern
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/bunit/Rendering/BunitRenderer.cs | Removed immediate exception assertion to prevent race conditions |
| tests/bunit.tests/BunitContextTest.cs | Updated test to use new exception handling pattern via Renderer.UnhandledException |
| docs/site/docs/interaction/dispose-components.md | Updated documentation to explain new consistent exception handling approach |
| docs/samples/tests/xunit/DisposeComponentsTest.cs | Updated sample code to demonstrate proper exception handling patterns |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DisposeComponentsdid check immediately forAssertNoUnhandledExceptionswhich can creates race conditions whenDisposeAsync/Disposethrows fast enough (aka in the sync part) but may behave oddly in the async part. Test201 was super flaky due this race condition.So this "take" consolidates a central way of getting an exception out of the "DisposeComponents" method