Add installer teardown for LUKS and LVM layouts#4496
Open
kill74 wants to merge 1 commit intoarchlinux:masterfrom
Open
Add installer teardown for LUKS and LVM layouts#4496kill74 wants to merge 1 commit intoarchlinux:masterfrom
kill74 wants to merge 1 commit intoarchlinux:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4491
PR Description
This PR adds a guarded teardown path to
Installerso archinstall cleans up the target storage stack after an installation attempt exits.The teardown runs from
Installer.__exit__()and is triggered only aftermount_ordered_layout()has started. It handles:The cleanup order follows the reverse of the setup topology:
Cleanup is best-effort so teardown does not mask the original installation error.
Tests and Checks
Ran successfully:
Attempted:
The pytest suite did not complete in the local WSL environment because test collection fails before reaching this change with an unrelated error from
archinstall/lib/output.py:That file is outside the scope of this PR.
Manual validation still needed on Arch/live ISO for:
/mntmounts after installer exit