Skip to content

Add interface to change LUKS iteration time #3634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svartkanin merged 13 commits into from
Jun 30, 2025
Merged

Add interface to change LUKS iteration time #3634

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
359a0d8
Added User Interface to change iteration time for LUKS encryption
haouarihk Jun 27, 2025
5cc6b20
removing unneessary try catch and imports
haouarihk Jun 27, 2025
c486017
used the same constant in luks.py file
haouarihk Jun 27, 2025
425ca5f
fixed issue with error firing in default value
haouarihk Jun 27, 2025
ab2e9ab
fixed ruf preview warnings
haouarihk Jun 27, 2025
e0e4b45
preview even if its default value. (iter_time)
haouarihk Jun 27, 2025
5f11476
check encryption type is not non before showing iter_time
haouarihk Jun 27, 2025
c7c838e
using _real_input with input_vp instead of _current_text
haouarihk Jun 27, 2025
23f0c8c
proper check for enc_type
haouarihk Jun 27, 2025
ae280bb
added Interation time to outer menu preview
haouarihk Jun 28, 2025
14d2bad
removed (ms) from title. so that we don't need to translate "Iteratio…
haouarihk Jun 28, 2025
cb7492e
a comment slipped in. this was not supposed to be in this pull
haouarihk Jun 28, 2025
ce00acd
fixed comparison str with EncryptionType
haouarihk Jun 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions archinstall/tui/curses_menu.py
View file
Open in desktop
Copy link
Copy Markdown
Contributor Author

@haouarihk haouarihk Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've been testing for quite a while.
and i found this to solve my issue with input persistancy.

there could be better solutions out there.
but i couldn't get _current_text to persist with the previewed value.

i also tested it in the other inputs and it seems to not effect them.

Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,10 @@ def _get_input_text(self) -> str | None:
entry = ViewportEntry(err, 0, 0, STYLE.ERROR)
self._info_vp.update([entry], 0)
self._set_default_info = False
self._real_input = ''

if self._hide_input:
self._real_input = ''

return None

return text
Expand All @@ -586,7 +589,7 @@ def _draw(self) -> None:
if self._set_default_info and self._info_vp:
self._info_vp.update([self._only_ascii_text], 0)

self._input_vp.edit(default_text=self._current_text)
self._input_vp.edit(default_text=self._real_input)

@override
def kickoff(self, win: curses.window) -> Result[str]:
Expand Down
Loading