Remove btrfs default structure prompt on default disk layout#3615
Closed
svartkanin wants to merge 1 commit intoarchlinux:masterfrom
Closed
Remove btrfs default structure prompt on default disk layout#3615svartkanin wants to merge 1 commit intoarchlinux:masterfrom
svartkanin wants to merge 1 commit intoarchlinux:masterfrom
Conversation
Torxed
approved these changes
Jun 22, 2025
Member
Torxed
left a comment
Torxed
left a comment
There was a problem hiding this comment.
I still think they should have the option to choose, but if it's broken then we should merge this and circle back later.
Collaborator
Author
|
What would be the actual flow though if someone chooses not to use the default structure? There's no other option at that point to add subvolumes |
Member
|
My understanding is that people use btrfs as a normal filesystem (like ext4) if no subvolumes were selected, and they can add some manually later. And if they select subvolumes they'll get some sensible defaults :) |
Collaborator
Author
|
Okay I tried to reproduce the problem mentioned without specifying subvolumes but everything seems to work fine. I'll decline this for now as it seems to be a working use case |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a previous issue related to an installation with BTRFS but no subvolumes #3477 (comment). In the default disk setup mode that is possible as there is a question to add the subvolumes or not which doesn't make much sense as choosing "no" will not actually work.
This removes the question if subolumes should be added in the default disk setup but still keeps the prompt in the manual partitioning menu as users are expected to be more advanced in there