Fix #2924: Align LV offset to PE boundary#3603
Merged
svartkanin merged 2 commits intoarchlinux:masterfrom Jun 17, 2025
Merged
Conversation
Collaborator
|
Thanks for the thorough description and analysis |
svartkanin
approved these changes
Jun 17, 2025
Collaborator
|
This might fix #3424 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2924
PR Description
When creating multiple Logical Volumes (LVs), the installer hangs indefinitely because subsequent volumes fail due to insufficient space. The code computed a raw byte offset between the desired LV size and the available VG space but didn’t account for LVM’s Physical Extent (PE) alignment, so
lvcreate’s internal rounding consumed extra PE and exhausted the VG.Solution: Pre‑align the offset calculation to the nearest PE (default 4 MiB) using
math.ceil(), ensuring that the final LV size matches expectations and preserves space for other volumes. (Perhaps the PE size could be retrieved dynamically fromvg_info.)Testing Results
Setup:
/boot+ 39 GiB encrypted LUKS PVBefore Fix
After Fix
Reference: lvcreate(8) man page