Remove unused context manager code from SysCommand#3562
Closed
correctmost wants to merge 1 commit intoarchlinux:masterfrom
Closed
Remove unused context manager code from SysCommand#3562correctmost wants to merge 1 commit intoarchlinux:masterfrom
correctmost wants to merge 1 commit intoarchlinux:masterfrom
Conversation
Member
|
Same thing here, internally we might not but one point of archinstall is to be able to use it as a library: |
Contributor
Author
|
I will leave the code in place and fix the annotations instead (in a separate PR) |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests and Checks
SysCommandused as a context manager when reviewing the various callers