Skip to content

Remove unused context manager code from AbstractMenu #3560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
correctmost wants to merge 1 commit into from
Closed

Remove unused context manager code from AbstractMenu #3560

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 2 additions & 20 deletions archinstall/lib/menu/abstract_menu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,13 @@
from __future__ import annotations

from typing import Any, Self
from typing import Any

from archinstall.lib.translationhandler import tr
from archinstall.tui.curses_menu import SelectMenu, Tui
from archinstall.tui.curses_menu import SelectMenu
from archinstall.tui.menu_item import MenuItem, MenuItemGroup
from archinstall.tui.result import ResultType
from archinstall.tui.types import Chars, FrameProperties, FrameStyle, PreviewStyle

from ..output import error

CONFIG_KEY = '__config__'


Expand All @@ -28,24 +26,8 @@ def __init__(
self._allow_reset = allow_reset
self._reset_warning = reset_warning

self.is_context_mgr = False

self._sync_from_config()

def __enter__(self, *args: Any, **kwargs: Any) -> Self:
self.is_context_mgr = True
return self

def __exit__(self, *args: Any, **kwargs: Any) -> None:
# TODO: https://stackoverflow.com/questions/28157929/how-to-safely-handle-an-exception-inside-a-context-manager
# TODO: skip processing when it comes from a planified exit
if len(args) >= 2 and args[1]:
error(args[1])
Tui.print('Please submit this issue (and file) to https://github.com/archlinux/archinstall/issues')
raise args[1]

self.sync_all_to_config()

def _sync_from_config(self) -> None:
for item in self._menu_item_group._menu_items:
if item.key is not None and not item.key.startswith(CONFIG_KEY):
Expand Down