Skip to content

Remove return value check for Installer.minimal_installation #3555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svartkanin merged 1 commit into from
May 30, 2025
+15 −15
Merged

Remove return value check for Installer.minimal_installation #3555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion archinstall/lib/installer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -824,7 +824,7 @@ def minimal_installation(
mkinitcpio: bool = True,
hostname: str | None = None,
locale_config: LocaleConfiguration | None = LocaleConfiguration.default(),
):
) -> None:
if self._disk_config.lvm_config:
lvm = 'lvm2'
self.add_additional_packages(lvm)
Expand Down
28 changes: 14 additions & 14 deletions archinstall/scripts/minimal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,25 +31,25 @@ def perform_installation(mountpoint: Path) -> None:
) as installation:
# Strap in the base system, add a boot loader and configure
# some other minor details as specified by this profile and user.
if installation.minimal_installation():
installation.set_hostname('minimal-arch')
installation.add_bootloader(Bootloader.Systemd)
installation.minimal_installation()
installation.set_hostname('minimal-arch')
installation.add_bootloader(Bootloader.Systemd)

network_config = config.network_config
network_config = config.network_config

if network_config:
network_config.install_network_config(
installation,
config.profile_config,
)
if network_config:
network_config.install_network_config(
installation,
config.profile_config,
)

installation.add_additional_packages(['nano', 'wget', 'git'])
installation.add_additional_packages(['nano', 'wget', 'git'])

profile_config = ProfileConfiguration(MinimalProfile())
profile_handler.install_profile_config(installation, profile_config)
profile_config = ProfileConfiguration(MinimalProfile())
profile_handler.install_profile_config(installation, profile_config)

user = User('devel', Password(plaintext='devel'), False)
installation.create_users(user)
user = User('devel', Password(plaintext='devel'), False)
installation.create_users(user)

# Once this is done, we output some useful information to the user
# And the installation is complete.
Expand Down