Skip to content

Remove some unnecessary None checks from desktop profile code#3546

Merged
Torxed merged 1 commit intoarchlinux:masterfrom
correctmost:cm/remove-some-none-checks
May 30, 2025
Merged

Remove some unnecessary None checks from desktop profile code#3546
Torxed merged 1 commit intoarchlinux:masterfrom
correctmost:cm/remove-some-none-checks

Conversation

@correctmost
Copy link
Copy Markdown
Contributor

PR Description:

This commit fixes some warnings reported by Pyright's reportUnnecessaryComparison checker:

archinstall/archinstall/default_profiles/desktops/hyprland.py:69:7 - error: Condition will always evaluate to True since the types "MenuItem" and "None" have no overlap (reportUnnecessaryComparison)
archinstall/archinstall/default_profiles/desktops/labwc.py:66:7 - error: Condition will always evaluate to True since the types "MenuItem" and "None" have no overlap (reportUnnecessaryComparison)
archinstall/archinstall/default_profiles/desktops/niri.py:74:7 - error: Condition will always evaluate to True since the types "MenuItem" and "None" have no overlap (reportUnnecessaryComparison)
archinstall/archinstall/default_profiles/desktops/sway.py:76:7 - error: Condition will always evaluate to True since the types "MenuItem" and "None" have no overlap (reportUnnecessaryComparison)

Tests and Checks

  • I have tested the code!

This commit fixes some warnings reported by Pyright's
reportUnnecessaryComparison checker.
@correctmost correctmost requested a review from Torxed as a code owner May 29, 2025 22:56
@Torxed Torxed merged commit b689656 into archlinux:master May 30, 2025
9 checks passed
@correctmost correctmost deleted the cm/remove-some-none-checks branch May 30, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants