Move disk encryption into disk config menu#3502
Merged
svartkanin merged 1 commit intoarchlinux:masterfrom May 25, 2025
Merged
Conversation
Member
|
I will adjust the test framework to reflect this. And I agree, it makes more sense to have it in there :) |
Torxed
approved these changes
May 25, 2025
Collaborator
Author
|
Thanks, the current unit tests are not able to cover the disk configurations as any config is only processed if the disk exists on the host running it. Maybe that could be mocked somehow |
Member
Probably can be mocked, but it's also covered in the integration test before release at least |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will move the disk encryption menu from the main menu into the disk configuration menu as it makes more sense to group it in there with the other disk related configurations.
The configuration file has also changed to reflect it and the
disk_encryptionis now inside thedisk_configblock. This change is backwards compatible though, so existing configuration files will still be parsed correctly.