Skip to content

Case insensitive sorting of profiles #3329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Torxed merged 2 commits into from
Apr 6, 2025
Merged

Case insensitive sorting of profiles #3329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f8f310
Case insensitive sorting of profiles
svartkanin Apr 2, 2025
d54eac5
Update
svartkanin Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion archinstall/default_profiles/desktop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def do_on_select(self) -> SelectResult | None:
) for p in profile_handler.get_desktop_profiles()
]

group = MenuItemGroup(items, sort_items=True)
group = MenuItemGroup(items, sort_items=True, sort_case_sensitive=False)
group.set_selected_by_value(self.current_selection)

result = SelectMenu(
Expand Down
6 changes: 5 additions & 1 deletion archinstall/tui/menu_item.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,17 @@ def __init__(
focus_item: MenuItem | None = None,
default_item: MenuItem | None = None,
sort_items: bool = False,
sort_case_sensitive: bool = True,
checkmarks: bool = False
) -> None:
if len(menu_items) < 1:
raise ValueError('Menu must have at least one item')

if sort_items:
menu_items = sorted(menu_items, key=lambda x: x.text)
if sort_case_sensitive:
menu_items = sorted(menu_items, key=lambda x: x.text)
else:
menu_items = sorted(menu_items, key=lambda x: x.text.lower())

if not focus_item:
focus_item = menu_items[0]
Expand Down