Skip to content

Move run_custom_user_commands to fix an import cycle#3254

Merged
svartkanin merged 1 commit intoarchlinux:masterfrom
correctmost:cm/fix-import-cycle
Mar 25, 2025
Merged

Move run_custom_user_commands to fix an import cycle#3254
svartkanin merged 1 commit intoarchlinux:masterfrom
correctmost:cm/fix-import-cycle

Conversation

@correctmost
Copy link
Copy Markdown
Contributor

@correctmost correctmost commented Mar 13, 2025

PR Description:

This commit fixes the following Pyright warning:

  archinstall/lib/general.py: error: Cycle detected in import chain
    archinstall/lib/general.py
    archinstall/lib/installer.py
    archinstall/lib/models/device_model.py
    archinstall/lib/hardware.py (reportImportCycles)

I marked this as a draft PR because it will cause merge conflicts with #3247.

@correctmost correctmost force-pushed the cm/fix-import-cycle branch from a7e838e to f379cef Compare March 25, 2025 18:59
@correctmost correctmost marked this pull request as ready for review March 25, 2025 19:01
@correctmost correctmost requested a review from Torxed as a code owner March 25, 2025 19:01
@svartkanin svartkanin merged commit d43482e into archlinux:master Mar 25, 2025
8 checks passed
@correctmost correctmost deleted the cm/fix-import-cycle branch March 25, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@svartkanin svartkanin svartkanin approved these changes

@Torxed Torxed Awaiting requested review from Torxed Torxed is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@correctmost @svartkanin