Skip to content

Commit de3416f

Browse files
authored
Start the boot partition at 1MiB by default on MBR too (#3344)
1 parent da29b31 commit de3416f

1 file changed

Lines changed: 1 addition & 12 deletions

File tree

archinstall/lib/interactions/disk_conf.py

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -232,11 +232,9 @@ def select_lvm_config(
232232
def _boot_partition(sector_size: SectorSize, using_gpt: bool) -> PartitionModification:
233233
flags = [PartitionFlag.BOOT]
234234
size = Size(1, Unit.GiB, sector_size)
235+
start = Size(1, Unit.MiB, sector_size)
235236
if using_gpt:
236-
start = Size(1, Unit.MiB, sector_size)
237237
flags.append(PartitionFlag.ESP)
238-
else:
239-
start = Size(3, Unit.MiB, sector_size)
240238

241239
# boot partition
242240
return PartitionModification(
@@ -362,15 +360,6 @@ def suggest_single_disk_layout(
362360
available_space = available_space.align()
363361

364362
# Used for reference: https://wiki.archlinux.org/title/partitioning
365-
# 2 MiB is unallocated for GRUB on BIOS. Potentially unneeded for other bootloaders?
366-
367-
# TODO: On BIOS, /boot partition is only needed if the drive will
368-
# be encrypted, otherwise it is not recommended. We should probably
369-
# add a check for whether the drive will be encrypted or not.
370-
371-
# Increase the UEFI partition if UEFI is detected.
372-
# Also re-align the start to 1MiB since we don't need the first sectors
373-
# like we do in MBR layouts where the boot loader is installed traditionally.
374363

375364
boot_partition = _boot_partition(sector_size, using_gpt)
376365
device_modification.add_partition(boot_partition)

0 commit comments

Comments
 (0)