Skip to content

fix: JavaBeanSerializeUtil handles null key in Map serialization #16435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waterWang wants to merge 2 commits into
base: 3.3
Choose a base branch
from
+23 −2
Open

fix: JavaBeanSerializeUtil handles null key in Map serialization #16435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7dae1d
fix: allow null key in Map serialization (JavaBeanDescriptor.setPrope…
waterWang Aug 25, 2026
64f1c89
test: add testSerialize_MapWithNullKey for null key round-trip
waterWang Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion dubbo-common/src/main/java/org/apache/dubbo/common/beanutil/JavaBeanDescriptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,9 @@ public void setClassName(String className) {
}

public Object setProperty(Object propertyName, Object propertyValue) {
notNull(propertyName, "Property name is null");
if (!isMapType()) {
notNull(propertyName, "Property name is null");
}
return properties.put(propertyName, propertyValue);
}

Expand Down
21 changes: 20 additions & 1 deletion dubbo-common/src/test/java/org/apache/dubbo/common/beanutil/JavaBeanSerializeUtilTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,26 @@ void testSerialize_Array() {
}

@Test
void testConstructorArg() {
public void testSerialize_MapWithNullKey() {
Map<String, String> map = new HashMap<>();
map.put("key1", "value1");
map.put(null, "nullKeyValue");

JavaBeanDescriptor descriptor = JavaBeanSerializeUtil.serialize(map);
Assertions.assertTrue(descriptor.isMapType());
Assertions.assertEquals(HashMap.class.getName(), descriptor.getClassName());
Assertions.assertEquals(2, descriptor.propertySize());

// round-trip
Object result = JavaBeanSerializeUtil.deserialize(descriptor);
Assertions.assertTrue(result instanceof Map);
Map<String, String> resultMap = (Map<String, String>) result;
Assertions.assertEquals("value1", resultMap.get("key1"));
Assertions.assertEquals("nullKeyValue", resultMap.get(null));
}

@Test
public void testConstructorArg() {
Assertions.assertFalse((boolean) JavaBeanSerializeUtil.getConstructorArg(boolean.class));
Assertions.assertFalse((boolean) JavaBeanSerializeUtil.getConstructorArg(Boolean.class));
Assertions.assertEquals((byte) 0, JavaBeanSerializeUtil.getConstructorArg(byte.class));
Expand Down
Loading