Remove bundled Python packages#982
Conversation
|
After deleting these files, I tested and found that we need to install the related Python dependencies after successfully building Cloudberry, so we can make all the tests pass: I'm still exploring how to install them in the workflow files. I would appreciate your help. |
tuhaihe
force-pushed
the
remove-bundles-pyfiles
branch
from
315d1d2 to
be81427
Compare
tuhaihe
force-pushed
the
remove-bundles-pyfiles
branch
from
1da8b7e to
e4874fc
Compare
tuhaihe
force-pushed
the
remove-bundles-pyfiles
branch
2 times, most recently
from
c364f1d to
e330ea1
Compare
This change removes the unnecessary bundled Python packages for a clear codebase and better ASF license compliance. Changes made: - Removed the `pythonSrc` and `pythonSrc/ext` directories from the source code. - Updated the `Makefile`, `configure` and other related files to remove the *pythonsrc_ext* related references. Instead building the Python packages like psutil, pygresql and pyyaml via the source code when running the Cloudberry Demo cluster, we can install them via the command under the top dir: ``` pip3 install -r requirements.txt ```
tuhaihe
force-pushed
the
remove-bundles-pyfiles
branch
from
e330ea1 to
694e4e9
Compare
There was a problem hiding this comment.
Copilot reviewed 38 out of 43 changed files in this pull request and generated no comments.
Files not reviewed (5)
- configure: Language not supported
- configure.ac: Language not supported
- gpAux/Makefile: Language not supported
- gpMgmt/Makefile: Language not supported
- src/Makefile.global.in: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/coverity.yml:109
- Confirm that the removal of the '--with-pythonsrc-ext' option in the Coverity workflow does not inadvertently impact any necessary Python component analysis or scanning.
--with-pythonsrc-ext \
|
For the test suite to run successfully, this additional command needs to be included in the apache-devops-release build script. If this PR seems good, then I can update the related file. This PR is experimental; if there are any issues, feel free to let me know. |
tuhaihe
changed the title
|
We need to cherry-pick these commits from GP to replace pygresql and other python packages with the distro's python packages: #1067. So close this PR. |
This change removes the unnecessary bundled Python packages for a clear
codebase and better ASF license compliance.
Changes made:
pythonSrcandpythonSrc/extdirectories from thesource code.
Makefile,configureand other related files to removethe pythonsrc_ext related references.
Instead building the Python packages like psutil, pygresql and pyyaml
via the source code when running the Cloudberry Demo cluster, we can
install them via the command under the top dir:
See #961
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions