ORCA: Fix missing the aggstar in AggRef#1051
Merged
jiaqizho merged 1 commit intoapache:mainfrom May 7, 2025
Merged
Conversation
jiaqizho
force-pushed
the
orca-support-agg-star
branch
from
9d42314 to
4549f76
Compare
jiaqizho
changed the title
jiaqizho
force-pushed
the
orca-support-agg-star
branch
from
4549f76 to
c82d072
Compare
my-ship-it
approved these changes
Apr 23, 2025
HuSen8891
approved these changes
May 6, 2025
jiaqizho
force-pushed
the
orca-support-agg-star
branch
from
c82d072 to
5e1e573
Compare
In the ORCA optimizer, `aggref->aggstar` is not filled. It will cause the executor to treat `count(*)` as `count()`. Although the results of `count()` and `count(*)` are the same. But without `aggstar=true` may affect the custom scan. Assuming that the storage engine pre-calculates the content of `count(*)` and uses `aggstar` to decide whether to use custom scan, the ORCA plan will cause the custom not work.
jiaqizho
force-pushed
the
orca-support-agg-star
branch
from
de16f6b to
5629020
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions