Skip to content

CI: Enable PAX module in Coverity scan workflow#1050

Merged
tuhaihe merged 1 commit intoapache:mainfrom
tuhaihe:fix-coverity
Apr 16, 2025
Merged

CI: Enable PAX module in Coverity scan workflow#1050
tuhaihe merged 1 commit intoapache:mainfrom
tuhaihe:fix-coverity

Conversation

@tuhaihe
Copy link
Copy Markdown
Member

@tuhaihe tuhaihe commented Apr 15, 2025

The PAX storage module was missing from the daily Coverity static analysis scan, which left potential code issues undetected. This change ensures PAX module is properly initialized and included in the scan process, providing better code quality coverage for the entire project.

Changes made:

  • Added git submodule update --init command before configure
  • Added --enable-pax flag to configure options

Before this PR, the Coverity scan had errors because of the PAX feature is introduced.

See: #1049

Fixes #ISSUE_Number

What does this PR do?

Type of Change

  • Bug fix (non-breaking change)
  • New feature (non-breaking change)
  • Breaking change (fix or feature with breaking changes)
  • Documentation update

Breaking Changes

Test Plan

  • Unit tests added/updated
  • Integration tests added/updated
  • Passed make installcheck
  • Passed make -C src/test installcheck-cbdb-parallel

Impact

Performance:

User-facing changes:

Dependencies:

Checklist

Additional Context

CI Skip Instructions


@my-ship-it my-ship-it requested a review from jiaqizho April 15, 2025 07:36
@tuhaihe tuhaihe mentioned this pull request Apr 15, 2025
12 tasks
@tuhaihe
Copy link
Copy Markdown
Member Author

tuhaihe commented Apr 15, 2025

Also can use the following setting to load the submodules:

    steps:
    - name: Checkout Apache Cloudberry
      uses: actions/checkout@v4
      with:
        fetch-depth: 1
        submodules: true

@tuhaihe
Copy link
Copy Markdown
Member Author

tuhaihe commented Apr 16, 2025

The Coverity scan workflow failed today again: https://github.com/apache/cloudberry/actions/runs/14481808387/job/40620110528 and returned the same error.
@jiaqizho could you help take a look at this PR? Thanks!

The PAX storage module was missing from the daily Coverity static analysis
scan, which left potential code issues undetected. This change ensures PAX
module is properly initialized and included in the scan process, providing
better code quality coverage for the entire project.

Changes made:
- Added `git submodule update --init` command before configure
- Added `--enable-pax` flag to configure options

Before this PR, the Coverity scan had errors because of the PAX feature
is introduced.

See: apache#1049
@tuhaihe tuhaihe merged commit 1cbab9b into apache:main Apr 16, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants