Cherry-pick AOCS related work that changes catalog version #1008
Open
reshke wants to merge 3 commits intoapache:mainfrom
Open
Cherry-pick AOCS related work that changes catalog version #1008reshke wants to merge 3 commits intoapache:mainfrom
reshke wants to merge 3 commits intoapache:mainfrom
Conversation
Member
|
cool, need a rebase. |
Member
|
Hi @reshke would you like to include this PR in the coming 2.0.0? If so, welcome to add this PR to the GitHub project. |
Contributor
Author
|
big thanks to @gfphoenix78 for taking care of it.... |
Contributor
Author
HI! lets approve it and merge |
On first index creation (block directory is created) and only that time all columns are scanned. Later any index creation just scans needed columns. cherry-picked. Note influence of greenplum-db/gpdb-archive@8c92aa0
We can get indexes for blkdir and visimap from pg_index via `RelationGetIndexList`. Removing these 2 fields will reduce catalog size. Basically, we now deal with these two properties in a more similar way as the indexes of toast tables, where we always open the toast table first and then get its index via `RelationGetIndexList`. In fact, in majority of the places currently we already have those two aux tables opened. The only place we didn't is in ATExecSetTableSpace(), but it shouldn't slow down that function too much anyway. The other notable thing is that we need to modify how we get these indexes in pg_dump - we now have to check the pg_index.
Contributor
Author
|
Did a rebase on fresh master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on issue #989 I realized we need to cherry-pick a couple of valuable contributions from GP7 to resolve diff easily. Also, there is a benefit of cherry-picking catalog-changing contributions before CBDB 2.0 release.
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions