docs(material/form-field): fix incorrect chip component reference#33161
Open
Will-thom wants to merge 1 commit intoangular:mainfrom
Open
docs(material/form-field): fix incorrect chip component reference#33161Will-thom wants to merge 1 commit intoangular:mainfrom
Will-thom wants to merge 1 commit intoangular:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
angular-robot
Bot
added
area: docs
Will-thom
force-pushed
the
fix/form-field-chip-doc
branch
from
e95ae12 to
03518a9
Compare
Replace mat-chip-set with mat-chip-grid in the form-field documentation, since only mat-chip-grid implements MatFormFieldControl. Closes angular#33035
Will-thom
force-pushed
the
fix/form-field-chip-doc
branch
from
03518a9 to
ea79898
Compare
Author
|
Hi @adolgachev or @crisbeto I've signed the CLA. Please let me know if anything else is needed 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix incorrect chips component in mat-form-field documentation
The documentation currently lists
mat-chip-setas compatible withmat-form-field, but it does not implementMatFormFieldControland results in the error:This PR updates the documentation to use
mat-chip-grid, which correctly implements the required interface.Additionally, a note was added to clarify that
mat-form-fieldrequires a component implementingMatFormFieldControl.Closes #33035