Skip to content

fix(material/datepicker): use custom colors for date range comparison example#33158

Closed
yousafravian wants to merge 1 commit intoangular:mainfrom
yousafravian:fix/issue-31663
Closed

fix(material/datepicker): use custom colors for date range comparison example#33158
yousafravian wants to merge 1 commit intoangular:mainfrom
yousafravian:fix/issue-31663

Conversation

@yousafravian
Copy link
Copy Markdown
Contributor

Fixes substandard colors used for the datepicker comparison ranges example since the migration to Material 3. Adds custom CSS variables to properly highlight in-range, overlap, and comparison states.

Fixes #31663

… example

    Fixes substandard colors used for the datepicker comparison ranges example since the migration to Material 3. Adds custom CSS variables to properly highlight in-range, overlap, and comparison states.

    Fixes angular#31663
@yousafravian
Copy link
Copy Markdown
Contributor Author

margin: 0 8px 16px 0;
}

.example-date-range-comparison-calendar {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is something we'd have to fix in the datepicker itself. Also I'm not sure we should be using error colors for this.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I'm gonna create another PR for this. Will close this one

@yousafravian
Copy link
Copy Markdown
Contributor Author

Closing this as we need to fix this in the component itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Datepicker comparison ranges uses substandard colors

2 participants