Add connect() to IpcHub interface - #213
Closed
danog wants to merge 6 commits into
Closed
Conversation
Contributor
Author
|
Ping @trowski, will likely need a major tag |
Member
|
I'd prefer if you'd keep upgrading to Psalm 6 out of this PR. I certainly understand why you'd be excited to do so, but it does make this rather noise compared to the interface change being proposed here. |
Contributor
Author
|
Ehh it would have to be done anyways, this just speeds up the process :) Did this mainly to avoid issues with legacy versions of Psalm when running locally |
Member
|
We've updated to Psalm 6, so now this has a lot of conflicts. 😝 I think the solution I outlined in #208 would make more sense, so I'm closing this PR . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #208