Skip to content
This repository was archived by the owner on Mar 8, 2019. It is now read-only.

Emission of :responseReady makes code exists before ical.fromURL callback is called #45

Description

@lpatire

This line:

204 this.emit(':responseReady');

is making the handler to return a response without waiting the ical.fromURL callback to be called.

Therefore, all the requests I'm sending receives a response as:

{ "version": "1.0", "response": { "shouldEndSession": true }, "sessionAttributes": { "STATE": "_SEARCHMODE" }, "userAgent": "ask-nodejs/1.0.25 Node/v6.10.3" }

After removing that line, the application gets back to normal responses!
Can we take it off?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions