Skip to content

ci: stop the testcontainers reaper from deleting live test databases #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NekoPunch (orangeCatDeveloper) wants to merge 1 commit into from
Closed

ci: stop the testcontainers reaper from deleting live test databases #1235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/pr-workflow.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ permissions:
jobs:
run-tests:
runs-on: ubuntu-latest
# A lost reaper handshake gets a package's containers pruned mid-run
# (testcontainers-go#3827); a throwaway runner needs no reaping anyway.
Comment on lines +32 to +33

@BenTheElder Benjamin Elder (BenTheElder) Aug 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should just fix the handshake. relying on "it's in CI" leads to bugs that cannot be tested locally.

@orangeCatDeveloper NekoPunch (orangeCatDeveloper) Aug 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally the reaper stays on and the blast radius of #3827 is small — worst case a flaky full-suite run, and the fix for that is upstream (testcontainers-go#3841, not yet merged).

Disabling Ryuk in CI is also what the testcontainers docs recommend: "We recommend using it only for Continuous Integration services that have their own mechanism to clean up resources." — a GitHub-hosted runner is a fresh VM discarded after the job, so there's nothing left to reap.

env:
TESTCONTAINERS_RYUK_DISABLED: "true"
steps:
- name: Checkout
uses: actions/checkout@fbc6f3992d24b796d5a048ff273f7fcc4a7b6c09 # v5.1.0
Expand Down
Loading