Skip to content

Resolve modernize-type-traits #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZigRazor merged 1 commit into from
Oct 13, 2025
Merged

Resolve modernize-type-traits #549

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 12 additions & 13 deletions include/CXXGraph/Utility/TypeTraits.hpp
100755 → 100644
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,10 @@ namespace CXXGraph {
// is_node type trait
template <typename T>
struct is_node
: std::integral_constant<
bool, std::is_same<Node<typename T::Node_t>,
typename std::remove_const<T>::type>::value> {};
: std::integral_constant<bool,
std::is_same_v<Node<typename T::Node_t>,
typename std::remove_const_t<T>>> {
};

template <typename T>
struct is_node<T*> : std::false_type {};
Expand All @@ -56,11 +57,10 @@ template <typename T>
struct is_node_ptr : std::false_type {};

template <typename T>
struct is_node_ptr<T*> : std::integral_constant<bool, is_node<T>::value> {};
struct is_node_ptr<T*> : std::integral_constant<bool, is_node_v<T>> {};

template <typename T>
struct is_node_ptr<shared<T>>
: std::integral_constant<bool, is_node<T>::value> {};
struct is_node_ptr<shared<T>> : std::integral_constant<bool, is_node_v<T>> {};

template <typename T>
inline constexpr bool is_node_ptr_v = is_node_ptr<T>::value;
Expand All @@ -75,10 +75,10 @@ inline constexpr bool all_are_node_ptrs_v = all_are_node_ptrs<T, Ts...>::value;

// is_edge type trait
template <typename T>
struct is_edge
: std::integral_constant<
bool, std::is_base_of<Edge<typename T::Node_t>,
typename std::remove_const<T>::type>::value> {};
struct is_edge : std::integral_constant<
bool, std::is_base_of_v<Edge<typename T::Node_t>,
typename std::remove_const_t<T>>> {
};

template <typename T>
struct is_edge<T*> : std::false_type {};
Expand All @@ -94,11 +94,10 @@ template <typename T>
struct is_edge_ptr : std::false_type {};

template <typename T>
struct is_edge_ptr<T*> : std::integral_constant<bool, is_edge<T>::value> {};
struct is_edge_ptr<T*> : std::integral_constant<bool, is_edge_v<T>> {};

template <typename T>
struct is_edge_ptr<shared<T>>
: std::integral_constant<bool, is_edge<T>::value> {};
struct is_edge_ptr<shared<T>> : std::integral_constant<bool, is_edge_v<T>> {};

template <typename T>
inline constexpr bool is_edge_ptr_v = is_edge_ptr<T>::value;
Expand Down
Loading