Skip to content

Resolve performance-for-range-copy #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZigRazor merged 1 commit into from
Oct 2, 2025
Merged

Resolve performance-for-range-copy #541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/FloydWarshallExample/floyd_warshall.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ int main() {
CXXGraph::FWResult res = graph.floydWarshall();
std::cout << "floyd Warshall Result: "
<< "\n";
for (auto i : res.result) {
for (const auto& i : res.result) {
std::cout << "distance of: " << i.first.first << " " << i.first.second
<< " = " << i.second << "\n";
}
Expand Down
2 changes: 1 addition & 1 deletion examples/PrimExample/prim_example.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ int main() {
auto res = graph.prim();
std::cout << "Prim Result: "
<< "\n";
for (auto edge : res.mst) {
for (const auto& edge : res.mst) {
std::cout << edge.first << " " << edge.second << "\n";
}
std::cout << "mstCost: " << res.mstCost << "\n";
Expand Down
6 changes: 3 additions & 3 deletions include/CXXGraph/Graph/Algorithm/TransitiveReduction_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ const Graph<T> Graph<T>::transitiveReduction() const {
CXXGraph::id_t edgeId = 0;
std::unordered_set<shared<const Node<T>>, nodeHash<T>> nodes =
this->getNodeSet();
for (auto x : nodes) {
for (auto y : nodes) {
for (const auto& x : nodes) {
for (const auto& y : nodes) {
if (this->findEdge(x, y, edgeId)) {
for (auto z : nodes) {
for (const auto& z : nodes) {
if (this->findEdge(y, z, edgeId)) {
if (this->findEdge(x, z, edgeId)) {
result.removeEdge(edgeId);
Expand Down
32 changes: 16 additions & 16 deletions include/CXXGraph/Graph/Graph_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ Graph<T>::Graph() {

template <typename T>
Graph<T>::Graph(const T_EdgeSet<T> &edgeSet) {
for (auto edgeIt : edgeSet) {
for (const auto& edgeIt : edgeSet) {
this->edgeSet.insert(edgeIt);
}
/* Caching the adjacency matrix */
Expand All @@ -62,7 +62,7 @@ T_EdgeVector<T> Graph<T>::getEdgeVector() const {
template <typename T>
void Graph<T>::setEdgeSet(const T_EdgeSet<T> &edgeSet) {
this->edgeSet.clear();
for (auto edgeIt : edgeSet) {
for (const auto& edgeIt : edgeSet) {
this->edgeSet.insert(edgeIt);
}
/* Caching the adjacency matrix */
Expand Down Expand Up @@ -169,7 +169,7 @@ void Graph<T>::removeEdge(const CXXGraph::id_t edgeId) {
int delIndex = -1;
int i = 0;
/* Removing the edge from the cached adjacency lists */
for (auto elem : (*cachedAdjListOut)[from]) {
for (const auto& elem : (*cachedAdjListOut)[from]) {
if (elem.second.get()->getId() == edgeId) {
delIndex = i;
break;
Expand All @@ -186,7 +186,7 @@ void Graph<T>::removeEdge(const CXXGraph::id_t edgeId) {

delIndex = -1;
i = 0;
for (auto elem : (*cachedAdjListIn)[to]) {
for (const auto& elem : (*cachedAdjListIn)[to]) {
if (elem.second.get()->getId() == edgeId) {
delIndex = i;
break;
Expand All @@ -205,7 +205,7 @@ void Graph<T>::removeEdge(const CXXGraph::id_t edgeId) {
if (!edgeOpt.value().get()->isDirected().value_or(false)) {
delIndex = -1;
i = 0;
for (auto elem : (*cachedAdjListOut)[to]) {
for (const auto& elem : (*cachedAdjListOut)[to]) {
if (elem.second.get()->getId() == edgeId) {
delIndex = i;
break;
Expand All @@ -222,7 +222,7 @@ void Graph<T>::removeEdge(const CXXGraph::id_t edgeId) {

delIndex = -1;
i = 0;
for (auto elem : (*cachedAdjListIn)[from]) {
for (const auto& elem : (*cachedAdjListIn)[from]) {
if (elem.second.get()->getId() == edgeId) {
delIndex = i;
break;
Expand Down Expand Up @@ -282,7 +282,7 @@ bool Graph<T>::findEdge(shared<const Node<T>> v1, shared<const Node<T>> v2,
if (cachedAdjListOut.get() != NULL && cachedAdjListOut->size() != 0) {
/* Searching for the edge using cached adjacency list out */

for (auto elem : (*cachedAdjListOut)[v1]) {
for (const auto& elem : (*cachedAdjListOut)[v1]) {
if (elem.first == v2) {
id = elem.second.get()->getId();
return true;
Expand All @@ -291,7 +291,7 @@ bool Graph<T>::findEdge(shared<const Node<T>> v1, shared<const Node<T>> v2,
} else {
/* Searching for the edge using edgeset */

for (auto e : this->edgeSet) {
for (const auto& e : this->edgeSet) {
if ((e->getNodePair().first == v1) && (e->getNodePair().second == v2)) {
id = e->getId();
return true;
Expand Down Expand Up @@ -661,7 +661,7 @@ Graph<T>::outNotInNeighbors(shared<const Node<T>> node) const {
auto nodeEdgePairsOut = cachedAdjListOut->at(node);

std::unordered_set<shared<const Node<T>>, nodeHash<T>> outNotInNeighbors;
for (auto pair : nodeEdgePairsOut) {
for (const auto& pair : nodeEdgePairsOut) {
if (pair.second->isDirected().value_or(false)) {
outNotInNeighbors.insert(pair.first);
}
Expand All @@ -687,7 +687,7 @@ Graph<T>::inNotOutNeighbors(shared<const Node<T>> node) const {
auto nodeEdgePairsIn = cachedAdjListIn->at(node);

std::unordered_set<shared<const Node<T>>, nodeHash<T>> inNotOutNeighbors;
for (auto pair : nodeEdgePairsIn) {
for (const auto& pair : nodeEdgePairsIn) {
if (pair.second->isDirected().value_or(false)) {
inNotOutNeighbors.insert(pair.first);
}
Expand Down Expand Up @@ -715,13 +715,13 @@ Graph<T>::inOrOutNeighbors(shared<const Node<T>> node) const {
std::unordered_set<shared<const Node<T>>, nodeHash<T>> inOrOutNeighbors;
if (cachedAdjListOut->find(node) != cachedAdjListOut->end()) {
auto nodeEdgePairsOut = cachedAdjListOut->at(node);
for (auto pair : nodeEdgePairsOut) {
for (const auto& pair : nodeEdgePairsOut) {
inOrOutNeighbors.insert(pair.first);
}
}
if (cachedAdjListIn->find(node) != cachedAdjListIn->end()) {
auto nodeEdgePairsIn = cachedAdjListIn->at(node);
for (auto pair : nodeEdgePairsIn) {
for (const auto& pair : nodeEdgePairsIn) {
inOrOutNeighbors.insert(pair.first);
}
}
Expand All @@ -746,7 +746,7 @@ Graph<T>::outNotInEdges(shared<const Node<T>> node) const {
auto nodeEdgePairsOut = cachedAdjListOut->at(node);

std::unordered_set<shared<const Edge<T>>, edgeHash<T>> outNotInEdges;
for (auto pair : nodeEdgePairsOut) {
for (const auto& pair : nodeEdgePairsOut) {
if (pair.second->isDirected().value_or(false)) {
outNotInEdges.insert(pair.second);
}
Expand All @@ -772,7 +772,7 @@ Graph<T>::inNotOutEdges(shared<const Node<T>> node) const {
auto nodeEdgePairsIn = cachedAdjListIn->at(node);

std::unordered_set<shared<const Edge<T>>, edgeHash<T>> inNotOutEdges;
for (auto pair : nodeEdgePairsIn) {
for (const auto& pair : nodeEdgePairsIn) {
if (pair.second->isDirected().value_or(false)) {
inNotOutEdges.insert(pair.second);
}
Expand Down Expand Up @@ -800,13 +800,13 @@ Graph<T>::inOrOutEdges(shared<const Node<T>> node) const {
std::unordered_set<shared<const Edge<T>>, edgeHash<T>> inOrOutEdges;
if (cachedAdjListOut->find(node) != cachedAdjListOut->end()) {
auto nodeEdgePairsOut = cachedAdjListOut->at(node);
for (auto pair : nodeEdgePairsOut) {
for (const auto& pair : nodeEdgePairsOut) {
inOrOutEdges.insert(pair.second);
}
}
if (cachedAdjListIn->find(node) != cachedAdjListIn->end()) {
auto nodeEdgePairsIn = cachedAdjListIn->at(node);
for (auto pair : nodeEdgePairsIn) {
for (const auto& pair : nodeEdgePairsIn) {
inOrOutEdges.insert(pair.second);
}
}
Expand Down
Loading