Skip to content

Fixes #530, by replacement of algorithm in HDRF and addition of member variable in Record#540

Merged
ZigRazor merged 3 commits intoZigRazor:masterfrom
brghash:update
Oct 2, 2025
Merged

Fixes #530, by replacement of algorithm in HDRF and addition of member variable in Record#540
ZigRazor merged 3 commits intoZigRazor:masterfrom
brghash:update

Conversation

@brghash
Copy link
Copy Markdown
Contributor

@brghash brghash commented Oct 1, 2025

Summary of changes

  • Replaced the dangerous lock algorithm in HDRF with a safer backoff algorithm
  • Introudced owns_lock member variable to Record class to stop the unlocking of unowned mutexes

Why

  • The recursive call of the lock algorithm of HDRF is potentially dangerous
  • The unlocking of unowned mutexes was caused by the releaseLock() function, as there was no check to see it was owned or not

Related issue

brghash added 3 commits October 1, 2025 15:29
@brghash
Fixes ZigRazor#530, replaces the dangerous recursive strategy in HDRF…
858f31b 
… with a safer backoff one. Stop the unlocking of unowned mutexes with the implementation of the owns_lock member variable.
@brghash
Fixed access of base class member variable onws_lock.
085bdd9
@brghash
Syntax fix
e1b7a4d
@ZigRazor ZigRazor merged commit ebed856 into ZigRazor:master Oct 2, 2025
10 of 17 checks passed
@brghash brghash deleted the update branch October 2, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZigRazor ZigRazor ZigRazor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PartitionTest.test_2 fails 50% of the time due to "unlock of unowned mutex" - MSVC

2 participants

@brghash @ZigRazor