Skip to content

Define empty destructors using default#539

Merged
ZigRazor merged 1 commit intoZigRazor:masterfrom
vil02:use_default_destructors
Oct 1, 2025
Merged

Define empty destructors using default#539
ZigRazor merged 1 commit intoZigRazor:masterfrom
vil02:use_default_destructors

Conversation

@vil02
Copy link
Copy Markdown
Contributor

@vil02 vil02 commented Oct 1, 2025

Types with user defined destructors (even empty) are not trivially destructible. This change allows further compiler optimizations.

@vil02 vil02 force-pushed the use_default_destructors branch from c62f17b to 1591c35 Compare October 1, 2025 10:31
@vil02 vil02 changed the title Declare empty destructors using default Define empty destructors using default Oct 1, 2025
Types with user defined destructors (even empty)
are not trivially destructible.
This change allows further compiler optimizations.
@vil02 vil02 force-pushed the use_default_destructors branch from 1591c35 to 17bd59d Compare October 1, 2025 10:37
@vil02
Copy link
Copy Markdown
Contributor Author

vil02 commented Oct 1, 2025

Regarding the failing ci - it seems to be related to #530.

Before I fixed the typo in the commit message the Windows build was fine:
https://github.com/ZigRazor/CXXGraph/actions/runs/18159087474
Afterwards, I reran it twice, and both Windows builds have failed:
https://github.com/ZigRazor/CXXGraph/actions/runs/18159368419
https://github.com/ZigRazor/CXXGraph/actions/runs/18159503163

I think it does not make sense to rerun it again.

@vil02 vil02 marked this pull request as ready for review October 1, 2025 10:59
@ZigRazor ZigRazor merged commit 6fab592 into ZigRazor:master Oct 1, 2025
9 of 17 checks passed
@vil02 vil02 deleted the use_default_destructors branch October 1, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants