Skip to content

feat: added tests for dial and minor changes#536

Merged
ZigRazor merged 1 commit intoZigRazor:masterfrom
Voidylikescandy:feat/dial-algorithm-tests
Sep 30, 2025
Merged

feat: added tests for dial and minor changes#536
ZigRazor merged 1 commit intoZigRazor:masterfrom
Voidylikescandy:feat/dial-algorithm-tests

Conversation

@Voidylikescandy
Copy link
Copy Markdown
Contributor

Fixes #61

Added some tests

  1. Zero weight edges, currently setting maxWeight = 0 causes an early exit, so had to set maxWeight > 0.
  2. Validation of multiedges with same end points, choose smaller weight.
  3. Multi edge and cycle behaviour check.
  4. Self loop
  5. Validate error when an edge claims it's weighted but does not tell us direction, had to create a custom class to validate this, as the existing constructors do not allow null weights.

Made a few minor changes to spellings, added comments to make it easier to understand some of the existing tests.

@Voidylikescandy
Copy link
Copy Markdown
Contributor Author

@ZigRazor, there seem to be some failing checks unrelated to my changes.
And the merge is blocked, what does it mean commits must have verified signatures?

@ZigRazor
Copy link
Copy Markdown
Owner

@ZigRazor, there seem to be some failing checks unrelated to my changes. And the merge is blocked, what does it mean commits must have verified signatures?

@Voidylikescandy Don't worry, for signature commit you have to commit with "-s" flag.
But it's ok!

@Voidylikescandy
Copy link
Copy Markdown
Contributor Author

OoOh, I see, do I have to recommit them? Or will it be merged?

@ZigRazor
Copy link
Copy Markdown
Owner

it will be merged

@Voidylikescandy
Copy link
Copy Markdown
Contributor Author

Alright, sure, thank you. :P

@ZigRazor ZigRazor merged commit a844bdc into ZigRazor:master Sep 30, 2025
13 of 23 checks passed
@Voidylikescandy Voidylikescandy deleted the feat/dial-algorithm-tests branch September 30, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tests on Dial Algorithm

2 participants