Refactor addEdge - removed duplicate insert#535
Merged
ZigRazor merged 1 commit intoZigRazor:masterfrom Sep 30, 2025
Merged
Conversation
ZigRazor
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title:
Fix duplicated insert in addEdge function (#533)
Related Issue:
Closes #533
Description:
This PR fixes a duplicated insert call in the addEdge function of Graph. Previously, the function was calling edgeSet.insert(edge) twice, which is unnecessary.
The changes include:
Removed the redundant edgeSet.insert(edge) call.
Refactored duplicate detection to use the return value of insert() for cleaner and more efficient code.
Maintained proper updates to cached adjacency lists for both directed and undirected edges.
Code Reference:
Original line: Graph_impl.hpp#L105-L105