Merged
Conversation
arcuri82
requested changes
Apr 24, 2026
|
|
||
| const stateBadgeClass = (state: ReviewState): string => { | ||
| switch (state) { | ||
| case "ACCEPTED": |
Contributor
There was a problem hiding this comment.
why is this using hard-code strings instead of accessing the enum ReviewState directly?
|
|
||
| const counts = useMemo(() => { | ||
| const c: Record<ReviewState, number> = { | ||
| "NOT-REVIEWED": 0, |
Contributor
There was a problem hiding this comment.
i m seeing these hard-code strings in several places... shouldn't use an enum and access the enum to avoid duplication?
| > | ||
| ALL ({testCases.length}) | ||
| </button> | ||
| {REVIEW_STATES.filter(s => s !== "PREVIOUSLY-ACCEPTED" && s !== "PREVIOUSLY-REJECTED").map(s => ( |
Contributor
There was a problem hiding this comment.
again, if we make any change to the name of these hard-code values, then many places around the code-base will break
| } | ||
|
|
||
| export const REVIEW_FILE_NAME = "report-review.json"; | ||
| export const REVIEW_SCHEMA_VERSION = "1.0"; |
Contributor
There was a problem hiding this comment.
i guess should use same version as WFC... at least for now, not going to have different version numbers that can evolve independently
| const out: Record<string, TestReview> = {}; | ||
| for (const [id, r] of Object.entries(reviews)) { | ||
| const comment = (r.comment ?? "").trim(); | ||
| if (r.state !== "NOT-REVIEWED" || comment !== "") { |
Contributor
There was a problem hiding this comment.
check all these hard-coded strings
arcuri82
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.