Skip to content

test: add Node loader TypeScript recipe - #6151

Open
colinhacks wants to merge 1 commit into
Unitech:developmentfrom
colinhacks:docs/nub-loader-pm2
Open

test: add Node loader TypeScript recipe#6151
colinhacks wants to merge 1 commit into
Unitech:developmentfrom
colinhacks:docs/nub-loader-pm2

Conversation

@colinhacks

Copy link
Copy Markdown

Adds a Node preload recipe for TypeScript processes using @nubjs/loader 0.8.3.

  • Covers fork and cluster startup, application-cwd loader resolution, daemon Node version, and source maps.
  • Covers readiness-based reload, graceful shutdown, and worker cleanup.

@colinhacks
colinhacks force-pushed the docs/nub-loader-pm2 branch 2 times, most recently from b88172e to 40ba312 Compare September 5, 2026 19:24
@CLAassistant

CLAassistant commented Sep 5, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@colinhacks
colinhacks marked this pull request as ready for review September 5, 2026 19:27
Copilot AI lite review requested due to automatic review settings September 5, 2026 19:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@colinhacks
colinhacks force-pushed the docs/nub-loader-pm2 branch 3 times, most recently from b840df5 to 2a0ce83 Compare September 5, 2026 19:34
@colinhacks
colinhacks marked this pull request as draft September 5, 2026 21:40
@colinhacks
colinhacks marked this pull request as ready for review September 5, 2026 21:44
colinhacks added a commit to colinhacks/frizz that referenced this pull request Sep 11, 2026
…rough the `gh` fallback

Two sources of low-value "CI awaiting approval" wakes, both seen on the
maintainer's board 2026-09-11 against microsoft/TypeScript#64248:

1. The checks stamp keys a verdict on the head so that red-again-on-a-new-
   commit speaks. A gated reading is not a verdict — the worker's one move is
   to ask for the approval, on any commit — yet a force-push while the gate
   was shut re-announced "WAITING FOR APPROVAL" for the new SHA three minutes
   after saying it for the old one. Gated-after-gated is now quiet whatever
   the head; gated after a real verdict still speaks.

2. `gh run list --json conclusion` prints `action_required` where the batched
   GraphQL poll prints `ACTION_REQUIRED`, and both readers compared the raw
   string against the upper-case word. Every tick the GraphQL batch failed
   (`fetch failed` on one request sends every armed ref down the fallback at
   once) read a gated fork PR as "✅ CI PASSED — 1 check green", and the next
   poll flipped it back: two wakes per blip on every gated watcher, one of
   them false. #64172 collected four such pairs; typeorm/typeorm#12842 and
   Unitech/pm2#6151 flipped together at six instants over three days.

Pinned in github-watch.test.ts (verbatim `gh run list` output beside the
verbatim one-entry rollup) and awaiting-watch.e2e.test.ts (a force-push
while gated; a tick served by the fallback). All four fail with the fix
reverted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants