fix(ui): resolve dropdown transparency issue in code block menu#9535
Open
ZAKIURREHMAN wants to merge 2 commits intoTriliumNext:mainfrom
Open
fix(ui): resolve dropdown transparency issue in code block menu#9535ZAKIURREHMAN wants to merge 2 commits intoTriliumNext:mainfrom
ZAKIURREHMAN wants to merge 2 commits intoTriliumNext:mainfrom
Conversation
dosubot
Bot
added
the
size:XS
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the CSS for the code block toolbar in CKEditor 5 to ensure dropdown panels have a white background. Feedback indicates that the new selectors are too broad and the use of !important may cause UI regressions in other components. Additionally, it is recommended to use theme-specific CSS variables instead of hardcoded hex colors to maintain consistency across different themes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve dropdown transparency issue in code block menu #9534