Conversation
… parse (issue_mojeslnq_ph73yy)
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e0ecdfa294
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - For phone registration, send the phone number to `auth.signUp({ phone, ... })` first, then call the returned `verifyOtp({ token })`. Do not swap the order. | ||
| ```js | ||
| const { data, error } = await auth.signInWithOtp({ phone: '13800138000' }) | ||
| const { data, error } = await auth.signUp({ phone: '13800138000' }) | ||
| const { data: loginData, error: loginError } = await data.verifyOtp({ token:'123456' }) |
There was a problem hiding this comment.
This section is under “Login Methods”, but it now instructs agents to use auth.signUp({ phone }) as the primary phone OTP path; that changes the flow from login to registration and can fail for existing accounts (or produce registration-specific behavior) when the user intent is sign-in. The repo’s own auth hints still define phone OTP login as auth.signInWithOtp({ phone }) (mcp/src/tools/app-auth.ts), so this prompt change can mislead generated auth code for normal phone login scenarios.
Useful? React with 👍 / 👎.
Attribution post-PR evaluation
Cases
|
1 participant
Attribution issue
Automation summary
callCloudApitool was returning raw Cloud API responses directly without normalization. This made the return structure inconsistent with other tools (likemanagePermissions,queryPermissions) which return structured envelopes{success, data, message}. The inconsistent format made it harder for agents to reliably parse results.mcp/src/tools/capi.tsto wrap the Cloud API result in a consistent envelope structure withsuccess,data, andmessagefields, matching the pattern used by other permission and management tools in the codebase.build-skills-repo.test.js,build-compat-config.test.js,skill-quality-standards.test.js) - all 10 tests passed. Thecapi.test.tsunit tests also pass.Changed files
doc/prompts/auth-web.mdxmcp/src/tools/capi.ts