Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions mcp/src/tools/gateway.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ const {
mockDeleteCustomDomain,
mockGetCloudBaseManager,
mockLogCloudBaseResult,
mockGetEnvId,
} = vi.hoisted(() => ({
mockGetAccessList: vi.fn(),
mockGetDomainList: vi.fn(),
Expand All @@ -26,11 +27,13 @@ const {
mockDeleteCustomDomain: vi.fn(),
mockGetCloudBaseManager: vi.fn(),
mockLogCloudBaseResult: vi.fn(),
mockGetEnvId: vi.fn(),
}));

vi.mock("../cloudbase-manager.js", () => ({
getCloudBaseManager: mockGetCloudBaseManager,
logCloudBaseResult: mockLogCloudBaseResult,
getEnvId: mockGetEnvId,
}));

function createMockServer() {
Expand Down Expand Up @@ -66,6 +69,7 @@ describe("gateway tools", () => {
beforeEach(() => {
vi.clearAllMocks();

mockGetEnvId.mockResolvedValue("env-test");
mockGetAccessList.mockResolvedValue({
Total: 1,
EnableService: true,
Expand Down
26 changes: 11 additions & 15 deletions mcp/src/tools/gateway.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
import { z } from "zod";
import { getCloudBaseManager, logCloudBaseResult } from "../cloudbase-manager.js";
import {
getCloudBaseManager,
getEnvId,
logCloudBaseResult,
} from "../cloudbase-manager.js";
import { ExtendedMcpServer } from "../server.js";
import { jsonContent } from "../utils/json-content.js";

Expand Down Expand Up @@ -71,18 +75,10 @@ function normalizeAccessPath(path: string | undefined): string {
return path.startsWith("/") ? path : `/${path}`;
}

function ensureGatewayEnvId(cloudBaseOptions?: { envId?: string }) {
const envId = cloudBaseOptions?.envId;
if (!envId) {
throw new Error("当前网关操作需要已绑定 envId");
}
return envId;
}

export function registerGatewayTools(server: ExtendedMcpServer) {
const cloudBaseOptions = server.cloudBaseOptions;
const getManager = () => getCloudBaseManager({ cloudBaseOptions });
const getGatewayEnvId = () => ensureGatewayEnvId(cloudBaseOptions);
const resolveEnvId = () => getEnvId(cloudBaseOptions);

const buildEnvelope = (
data: Record<string, unknown>,
Expand Down Expand Up @@ -129,7 +125,7 @@ export function registerGatewayTools(server: ExtendedMcpServer) {
const listHttpServiceRoutes = async (domain?: string) => {
const cloudbase = await getManager();
const result = await cloudbase.env.describeHttpServiceRoute({
EnvId: getGatewayEnvId(),
EnvId: await resolveEnvId(),
...(domain
? {
Filters: [
Expand Down Expand Up @@ -177,7 +173,7 @@ export function registerGatewayTools(server: ExtendedMcpServer) {
}

return {
EnvId: getGatewayEnvId(),
EnvId: await resolveEnvId(),
Domain: {
Domain: await resolveRouteDomain(domain),
Routes: [
Expand Down Expand Up @@ -423,7 +419,7 @@ export function registerGatewayTools(server: ExtendedMcpServer) {
const cloudbase = await getManager();
const domain = await resolveRouteDomain(input.domain);
const result = await cloudbase.env.deleteHttpServiceRoute({
EnvId: getGatewayEnvId(),
EnvId: await resolveEnvId(),
Domain: domain,
Paths: [normalizeAccessPath(routePath)],
} as any);
Expand All @@ -445,7 +441,7 @@ export function registerGatewayTools(server: ExtendedMcpServer) {
}
const cloudbase = await getManager();
const result = await cloudbase.env.bindCustomDomain({
EnvId: getGatewayEnvId(),
EnvId: await resolveEnvId(),
Domain: {
Domain: input.domain,
CertId: input.certificateId,
Expand All @@ -469,7 +465,7 @@ export function registerGatewayTools(server: ExtendedMcpServer) {
}
const cloudbase = await getManager();
const result = await cloudbase.env.deleteCustomDomain({
EnvId: getGatewayEnvId(),
EnvId: await resolveEnvId(),
Domain: input.domain,
});
logCloudBaseResult(server.logger, result);
Expand Down
Loading